Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #751:
VALID_REASONING_EFFORTSlocally rejectedmaxandultra, so the flagship model's top two reasoning tiers were unreachable from the plugin (the request failed locally before any API call).Changes
plugins/codex/scripts/codex-companion.mjs— addedmaxandultratoVALID_REASONING_EFFORTS, updated the usage string inprintUsage(), and updated the error text innormalizeReasoningEffort().plugins/codex/commands/rescue.md— updatedargument-hintto includemax|ultra.plugins/codex/skills/codex-cli-runtime/SKILL.md— updated the documented--effortaccepted values.tests/commands.test.mjs— updated the two assertions that spell out the effort list.tests/runtime.test.mjs— added tests verifying--effort maxand--effort ultraare accepted and forwarded, and that unknown efforts are still rejected locally with the updated message.Verification
node --test tests/commands.test.mjs tests/runtime.test.mjs— 71/71 pass (69 existing + 2 new).The gate still discriminates:
--effort bogusis rejected locally (exit 1, no API call).