Skip to content

ci: skip Bun setup for Windows package verification - #404

Open
mldangelo-oai wants to merge 1 commit into
mainfrom
mdangelo/codex/skip-bun-windows-package-verify
Open

ci: skip Bun setup for Windows package verification#404
mldangelo-oai wants to merge 1 commit into
mainfrom
mdangelo/codex/skip-bun-windows-package-verify

Conversation

@mldangelo-oai

Copy link
Copy Markdown
Collaborator

Summary

Skip Bun installation in the Windows package-verification jobs, which use only Node.js and pnpm.

Changes

  • Remove the unused Bun setup step from the two windows-verify matrix jobs.
  • Keep Bun setup for the main test matrix and all Windows test shards.

Testing

  • bun test tests-ts/release-automation.test.ts tests-ts/package-provenance.test.ts --timeout 30000 — 195 passed.
  • pnpm pack --pack-destination /private/tmp/codex-security-cleanup-tools/followup-1 — passed without Bun on PATH.
  • npm_config_cache=/private/tmp/codex-security-cleanup-tools/npm-cache node scripts/check-package.mjs /private/tmp/codex-security-cleanup-tools/followup-1/openai-codex-security-0.1.11.tgz — passed.
  • prettier --check .github/workflows/node-ci.yml — passed.
  • git diff --check — passed.

Risk and rollout

Package builds, installed-package smoke tests, and release provenance use Node.js and pnpm. Every job that actually runs Bun tests retains its existing Bun installation.

Public disclosure review

  • No customer, partner, prospect, or user identities, data, or identifying details are included.
  • No credentials, personal data, private source, scan findings, or nonpublic links or tickets are included.
  • I reviewed the branch name, title, description, commits, changes, comments, logs, screenshots, attachments, and links for public disclosure.

@mldangelo-oai

Copy link
Copy Markdown
Collaborator Author

@codex review

@mldangelo-oai

Copy link
Copy Markdown
Collaborator Author

@codex security review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. You're on a roll.

Reviewed commit: 55ebd0c2ba

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

Security review completed. No security issues were found in this pull request.

Reviewed commit: 55ebd0c2ba

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@chatgpt-codex-connector

Copy link
Copy Markdown

Security review completed. No security issues were found in this pull request.

Reviewed commit: 55ebd0c2ba

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@zcrab-oai zcrab-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Windows package verification uses Node and pnpm only, while Bun remains installed for the actual Windows test shards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants