ci: skip Bun setup for Windows package verification - #404
Conversation
|
@codex review |
|
@codex security review |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Security review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
Security review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
zcrab-oai
left a comment
There was a problem hiding this comment.
Looks good. Windows package verification uses Node and pnpm only, while Bun remains installed for the actual Windows test shards.
Summary
Skip Bun installation in the Windows package-verification jobs, which use only Node.js and pnpm.
Changes
windows-verifymatrix jobs.Testing
bun test tests-ts/release-automation.test.ts tests-ts/package-provenance.test.ts --timeout 30000— 195 passed.pnpm pack --pack-destination /private/tmp/codex-security-cleanup-tools/followup-1— passed without Bun onPATH.npm_config_cache=/private/tmp/codex-security-cleanup-tools/npm-cache node scripts/check-package.mjs /private/tmp/codex-security-cleanup-tools/followup-1/openai-codex-security-0.1.11.tgz— passed.prettier --check .github/workflows/node-ci.yml— passed.git diff --check— passed.Risk and rollout
Package builds, installed-package smoke tests, and release provenance use Node.js and pnpm. Every job that actually runs Bun tests retains its existing Bun installation.
Public disclosure review