test(api): share prepared runtime fixtures - #405
Conversation
|
@codex review |
|
@codex security review |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Security review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
zcrab-oai
left a comment
There was a problem hiding this comment.
Looks good. Shared prepared-runtime fixtures preserve fresh per-test state and existing authentication, provider, and cancellation coverage.
Summary
Share the identical prepared-runtime fixture used by three API test suites.
Changes
Testing
bun test tests-ts/api.test.ts tests-ts/api-post-scan.test.ts tests-ts/api-surface.test.ts tests-ts/api-events.test.ts --timeout 30000(158 passed).pnpm --pm-on-fail=ignore run types.prettier --checkfor all four changed test files.git diff --check.Risk and rollout
Test-only cleanup. The shared helper returns the same values as each removed local helper, and no production or packaged files change.
Public disclosure review