Skip to content

test(api): share prepared runtime fixtures - #405

Merged
mldangelo-oai merged 1 commit into
mainfrom
mdangelo/codex/share-prepared-runtime-fixture
Aug 14, 2026
Merged

test(api): share prepared runtime fixtures#405
mldangelo-oai merged 1 commit into
mainfrom
mdangelo/codex/share-prepared-runtime-fixture

Conversation

@mldangelo-oai

Copy link
Copy Markdown
Collaborator

Summary

Share the identical prepared-runtime fixture used by three API test suites.

Changes

  • Move the existing fixture into the API test support module.
  • Import the shared fixture from the orchestration, post-scan, and API-surface tests.
  • Remove duplicate plugin-root imports and unchanged local fixture implementations.

Testing

  • bun test tests-ts/api.test.ts tests-ts/api-post-scan.test.ts tests-ts/api-surface.test.ts tests-ts/api-events.test.ts --timeout 30000 (158 passed).
  • pnpm --pm-on-fail=ignore run types.
  • prettier --check for all four changed test files.
  • git diff --check.

Risk and rollout

Test-only cleanup. The shared helper returns the same values as each removed local helper, and no production or packaged files change.

Public disclosure review

  • No customer, partner, prospect, or user identities, data, or identifying details are included.
  • No credentials, personal data, private source, scan findings, or nonpublic links or tickets are included.
  • I reviewed the branch name, title, description, commits, changes, comments, logs, screenshots, attachments, and links for public disclosure.

@github-actions github-actions Bot added the skip-release-notes Omit internal changes from generated release notes label Aug 14, 2026
@mldangelo-oai

Copy link
Copy Markdown
Collaborator Author

@codex review

@mldangelo-oai

Copy link
Copy Markdown
Collaborator Author

@codex security review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Can't wait for the next one!

Reviewed commit: 93c3e443e3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

Security review completed. No security issues were found in this pull request.

Reviewed commit: 93c3e443e3

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@zcrab-oai zcrab-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Shared prepared-runtime fixtures preserve fresh per-test state and existing authentication, provider, and cancellation coverage.

@mldangelo-oai
mldangelo-oai merged commit d48339a into main Aug 14, 2026
34 checks passed
@mldangelo-oai
mldangelo-oai deleted the mdangelo/codex/share-prepared-runtime-fixture branch August 14, 2026 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-release-notes Omit internal changes from generated release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants