Skip to content

test(release): remove redundant workflow source assertion - #406

Open
mldangelo-oai wants to merge 1 commit into
mainfrom
mdangelo/codex/remove-brittle-release-source-test
Open

test(release): remove redundant workflow source assertion#406
mldangelo-oai wants to merge 1 commit into
mainfrom
mdangelo/codex/remove-brittle-release-source-test

Conversation

@mldangelo-oai

Copy link
Copy Markdown
Collaborator

Summary

Remove a brittle release-workflow source assertion already covered by an executable behavior test.

Changes

  • Delete the substring-only concurrent-label-creation test.
  • Preserve the existing test that executes the workflow and verifies recovery when concurrent label creation fails.

Testing

  • bun test tests-ts/release-automation.test.ts --timeout 30000 (189 passed).
  • pnpm --pm-on-fail=ignore run types.
  • prettier --check tests-ts/release-automation.test.ts.
  • git diff --check.

Risk and rollout

Test-only deletion. The stronger executable workflow regression and every production release safeguard remain unchanged.

Public disclosure review

  • No customer, partner, prospect, or user identities, data, or identifying details are included.
  • No credentials, personal data, private source, scan findings, or nonpublic links or tickets are included.
  • I reviewed the branch name, title, description, commits, changes, comments, logs, screenshots, attachments, and links for public disclosure.

@mldangelo-oai

Copy link
Copy Markdown
Collaborator Author

@codex review

@mldangelo-oai

Copy link
Copy Markdown
Collaborator Author

@codex security review

@github-actions github-actions Bot added the skip-release-notes Omit internal changes from generated release notes label Aug 14, 2026
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. More of your lovely PRs please.

Reviewed commit: 68109f4b54

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

Security review completed. No security issues were found in this pull request.

Reviewed commit: 68109f4b54

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-release-notes Omit internal changes from generated release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant