test(runtime): share bundled runtime source loader - #407
Open
mldangelo-oai wants to merge 1 commit into
Open
Conversation
Collaborator
Author
|
@codex review |
Collaborator
Author
|
@codex security review |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Security review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Read and decompress the bundled runtime once for tests that inspect its immutable source.
Changes
Testing
bun test tests-ts/completed-scan-handoff.test.ts tests-ts/prompt-only-start-timeout.test.ts tests-ts/deep-scan-reducer-recovery.test.ts tests-ts/deep-scan-worker-shutdown.test.ts --timeout 30000(9 passed).bun test tests-ts/runtime.test.ts --timeout 30000(117 passed; 7 platform-specific tests skipped).pnpm --pm-on-fail=ignore run types.prettier --checkfor all five changed test files.git diff --check.Risk and rollout
Test-only cleanup. Only immutable decompressed source is cached; evaluated functions, fixture objects, cancellation behavior, and production packages remain unchanged.
Public disclosure review