fix(runtime): allow safe relative executable PATH entries - #408
Conversation
|
@codex review |
|
@codex security review |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Security review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
@codex review |
|
@codex security review |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Security review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
zcrab-oai
left a comment
There was a problem hiding this comment.
Looks good. Relative executable search paths are canonicalized safely while repository-controlled paths and Windows executable protections remain enforced.
Summary
Allow a user-selected relative executable search path when it resolves outside the scanned repository.
Changes
Testing
bun test tests-ts/trusted-executable.test.ts tests-ts/targets.test.ts tests-ts/multiscan.test.ts tests-ts/bulk-scan-discovery.test.ts --timeout 30000(71 passed; 1 Windows-only test skipped).bun test tests-ts/runtime.test.ts --timeout 30000(117 passed; 7 Windows-only tests skipped).pnpm --pm-on-fail=ignore run types.prettier --check src/trusted-executable.ts tests-ts/trusted-executable.test.ts.git diff --check.Risk and rollout
The resolved executable and inherited PATH remain canonical absolute paths outside the protected repository. Existing repository-shim, symlink, Windows extension, case-insensitive PATH, and credential-configuration protections are unchanged.
Public disclosure review