fix(cli): keep optional update notices nonblocking - #409
Conversation
|
@codex review |
|
@codex security review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 776baaefc2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Security review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
Security review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
@codex review |
|
@codex security review |
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Security review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
zcrab-oai
left a comment
There was a problem hiding this comment.
Looks good. Optional update notices remain nonblocking and unfinished registry requests are canceled without affecting command results.
Summary
Keep optional update checks from delaying CLI output or leaving registry requests active after a command finishes.
Changes
Testing
bun test tests-ts/update-notice.test.ts tests-ts/cli.test.ts tests-ts/cli-signals.test.ts tests-ts/cli-authentication.test.ts --timeout 30000(168 passed).bun test tests-ts/update-notice.test.ts --timeout 30000after the final simplification (11 passed).pnpm --pm-on-fail=ignore run types.prettier --check src/cli.ts src/version.ts tests-ts/cli-fixtures.ts tests-ts/update-notice.test.ts.git diff --check.Risk and rollout
Only optional update reporting changes. Ready notices, registry configuration, command output, credential handling, signal behavior, timeout limits, and suppression for CI, help, dry runs, and noninteractive output remain covered.
Public disclosure review