fix(preflight): accept valid Unicode progress issues - #413
Conversation
|
@codex review |
|
@codex security review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aa1960ffa9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Security review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
@codex review |
|
@codex security review |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Security review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
Summary
Accept valid non-ASCII preflight issues that fit the existing upstream count and character limits but exceed an unnecessary local byte limit.
Changes
--preflight-issues-jsontransport using a Unicode payload larger than 64 KiB that still fits the native Windows command-line limit.Testing
bun test tests-ts/workbench-progress.test.ts tests-ts/worker-progress.test.tspassed: 14 tests.bun test --timeout 30000 tests-ts/runtime.test.ts --test-name-pattern 'preflight|workbench commands'passed: four tests.pnpm --pm-on-fail=ignore run typespassed.pnpm --pm-on-fail=ignore exec prettier --check tests-ts/workbench-progress.test.tspassed.git diff --checkpassed.Risk and rollout
Low risk. Only a redundant byte-count rejection is removed; the actual upstream array and per-field contracts remain enforced. The regression follows the production argument transport and remains below the Windows command-line ceiling while exceeding the removed byte limit.
Public disclosure review