Skip to content

fix(preflight): accept valid Unicode progress issues - #413

Open
mldangelo-oai wants to merge 2 commits into
mainfrom
mdangelo/codex/accept-unicode-preflight-issues
Open

fix(preflight): accept valid Unicode progress issues#413
mldangelo-oai wants to merge 2 commits into
mainfrom
mdangelo/codex/accept-unicode-preflight-issues

Conversation

@mldangelo-oai

@mldangelo-oai mldangelo-oai commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator

Summary

Accept valid non-ASCII preflight issues that fit the existing upstream count and character limits but exceed an unnecessary local byte limit.

Changes

  • Remove the redundant 64 KiB serialized preflight-issue limit.
  • Preserve the existing 32-issue limit, UTF-16-aware field limits, severity and status validation, scan ownership checks, and progress phase restrictions.
  • Exercise the actual workbench argument parser and production --preflight-issues-json transport using a Unicode payload larger than 64 KiB that still fits the native Windows command-line limit.

Testing

  • bun test tests-ts/workbench-progress.test.ts tests-ts/worker-progress.test.ts passed: 14 tests.
  • bun test --timeout 30000 tests-ts/runtime.test.ts --test-name-pattern 'preflight|workbench commands' passed: four tests.
  • pnpm --pm-on-fail=ignore run types passed.
  • pnpm --pm-on-fail=ignore exec prettier --check tests-ts/workbench-progress.test.ts passed.
  • Python AST parsing and git diff --check passed.

Risk and rollout

Low risk. Only a redundant byte-count rejection is removed; the actual upstream array and per-field contracts remain enforced. The regression follows the production argument transport and remains below the Windows command-line ceiling while exceeding the removed byte limit.

Public disclosure review

  • No customer, partner, prospect, or user identities, data, or identifying details are included.
  • No credentials, personal data, private source, scan findings, or nonpublic links or tickets are included.
  • I reviewed the branch name, title, description, commits, changes, comments, logs, screenshots, attachments, and links for public disclosure.

@mldangelo-oai

Copy link
Copy Markdown
Collaborator Author

@codex review

@github-actions github-actions Bot added the bug Something isn't working label Aug 14, 2026
@mldangelo-oai

Copy link
Copy Markdown
Collaborator Author

@codex security review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: aa1960ffa9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread sdk/typescript/tests-ts/workbench-progress.test.ts Outdated
@chatgpt-codex-connector

Copy link
Copy Markdown

Security review completed. No security issues were found in this pull request.

Reviewed commit: aa1960ffa9

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@mldangelo-oai

Copy link
Copy Markdown
Collaborator Author

@codex review

@mldangelo-oai

Copy link
Copy Markdown
Collaborator Author

@codex security review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Can't wait for the next one!

Reviewed commit: 2a36c1ac23

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

Security review completed. No security issues were found in this pull request.

Reviewed commit: 2a36c1ac23

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant