fix(skills): align compact diff validation and attack paths - #414
Conversation
|
@codex review |
|
@codex security review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2be96c5a27
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Security review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
@codex review |
|
@codex security review |
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Security review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
zcrab-oai
left a comment
There was a problem hiding this comment.
Looks good. Compact diff validation and attack-path guidance now aligns with the existing candidate lifecycle while preserving SDK-owned completion.
Summary
Make bundled validation, attack-path, artifact, and final-report instructions match the compact candidate lifecycle already used by workbench-backed diff scans.
Changes
Testing
bun test --timeout 30000 tests-ts/compact-diff-scan.test.tspassed: five tests, including the complete MCP diff lifecycle and suppressed-candidate coverage.bun test --timeout 30000 tests-ts/deep-scan-workbench.test.ts --test-name-pattern 'candidate|validation|attack|discovery'passed: 14 tests.pnpm --pm-on-fail=ignore run typespassed.pnpm --pm-on-fail=ignore exec prettier --check _bundled_plugin/references/final-report.md _bundled_plugin/references/scan-artifacts.md _bundled_plugin/skills/validation/SKILL.md _bundled_plugin/skills/attack-path-analysis/SKILL.mdpassed.git diff --checkpassed.Risk and rollout
Low risk. This changes bundled instructions and shared references only. Existing Deep scans, terminal diff scans, candidate schemas, workbench ownership checks, evidence preservation, and scan finalization behavior remain unchanged.
Public disclosure review