fix(triage): honor explicitly selected GitHub connectors - #415
Conversation
|
@codex review |
|
@codex security review |
|
Security review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b2bd242307
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
@codex security review |
|
Security review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
zcrab-oai
left a comment
There was a problem hiding this comment.
Looks good. Explicit GitHub connector, account, and credential selections are honored without silent authorization-boundary fallback.
Summary
Honor an explicitly selected GitHub Connector, REST account, or credential source instead of silently switching finding intake to another authorization boundary.
Changes
Testing
bun test --timeout 30000 tests-ts/runtime.test.ts --test-name-pattern 'keeps installed-package plugin lookup inside the package|projects only the unchanged external payload|creates the SDK marketplace around a validated plugin'passed: three tests and 223 assertions.pnpm --pm-on-fail=ignore run typespassed.pnpm --pm-on-fail=ignore exec prettier --check _bundled_plugin/skills/triage-finding/SKILL.md _bundled_plugin/skills/triage-finding/references/github-rest-intake.mdpassed.git diff --checkpassed.Risk and rollout
Low risk. This modifies bundled instructions only. Existing default REST intake, source selection, read-only triage, token redaction, and explicit issue selection remain unchanged; explicit user transport and credential choices define the authorization boundary unless another choice is approved.
Public disclosure review