fix(models): route falsey mapped providers - #3996
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes
MultiProviderrouting for explicitly mapped provider objects that evaluate to false. The prefix resolver now distinguishes a missing map entry withis not None, so an explicitMultiProviderMapentry continues to win over built-in and unknown-prefix behavior regardless of the provider's truth value.Test plan
test_provider_map_routes_to_falsey_provider, which failed withUserError: Unknown prefix: custombefore the fix and passes afterward.tests/models/test_map.py: 15 passed..agents/skills/code-change-verification/scripts/run.sh:Operation not permitted.Issue number
N/A - found through code-path review; no existing issue or pull request covers falsey mapped-provider routing.
Checks
.agents/skills/code-change-verification/scripts/run.sh/reviewbefore submitting this PR