إنشاء datadog-synthetics.yml#2008
Conversation
|
@copilot |
There was a problem hiding this comment.
Pull request overview
Adds a new GitHub Actions workflow intended to run Datadog Synthetic tests for this repository.
Changes:
- Introduces
.github/workflows/datadog-synthetics.ymlto run Datadog Synthetics CI on pushes/PRs tomain.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1e61bafdb8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| api_key: ${{secrets.DD_API_KEY}} | ||
| app_key: ${{secrets.DD_APP_KEY}} |
There was a problem hiding this comment.
Skip the secret-dependent job for fork pull requests
For pull requests from forks, GitHub does not provide repository secrets, so both inputs resolve to empty values and this action cannot authenticate to Datadog. This repository explicitly runs CI for fork PRs (see the github.event.pull_request.head.repo.fork predicates in .github/workflows/ci.yml), so every external contribution targeting main will acquire a failing Datadog check after this workflow lands. Add a job condition that skips fork PRs (or limit this workflow to trusted pushes/internal PRs).
Useful? React with 👍 / 👎.
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v4 |
There was a problem hiding this comment.
Pin the checkout action to an immutable commit
Unlike the other workflows in this repository, this step references the mutable v4 tag rather than a full commit SHA. A future retarget of that tag can change what runs in the trusted main-push workflow without a reviewed repository change, making this credential-bearing CI path non-reproducible and weakening the supply-chain pinning used elsewhere. Pin actions/checkout to a reviewed SHA instead.
Useful? React with 👍 / 👎.
| branches: [ "main" ] | ||
|
|
||
| jobs: | ||
| build: |
Changes being requested
Additional context & links