Skip to content

ci: stop required checks from skipping when locks fail #3756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lazerg wants to merge 2 commits into
base: main
Choose a base branch
from
+50 −4
Open

ci: stop required checks from skipping when locks fail #3756

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c63e4d
ci: stop required checks from skipping when locks fail
lazerg Aug 28, 2026
19fe1e9
ci: pin the dependency lock guard with a regression test
lazerg Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 37 additions & 4 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,17 @@ jobs:
name: lint
runs-on: ubuntu-latest
needs: dependency-locks
if: github.event_name == 'push' || github.event_name == 'merge_group' || github.event.pull_request.head.repo.fork
if: >-
!cancelled()
&& (github.event_name == 'push' || github.event_name == 'merge_group' || github.event.pull_request.head.repo.fork)
steps:
# A skipped required check counts as satisfied, so refuse here instead of skipping.
- name: Require fresh dependency locks
if: needs.dependency-locks.result != 'success'
run: |
echo 'Refuse to run without verified dependency locks.' >&2
exit 1

- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
persist-credentials: false
Expand All @@ -93,13 +102,21 @@ jobs:

build:
needs: dependency-locks
if: github.event_name == 'push' || github.event_name == 'merge_group' || github.event.pull_request.head.repo.fork
if: >-
!cancelled()
&& (github.event_name == 'push' || github.event_name == 'merge_group' || github.event.pull_request.head.repo.fork)
timeout-minutes: 10
name: build
permissions:
contents: read
runs-on: ubuntu-latest
steps:
- name: Require fresh dependency locks
if: needs.dependency-locks.result != 'success'
run: |
echo 'Refuse to run without verified dependency locks.' >&2
exit 1

- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
persist-credentials: false
Expand Down Expand Up @@ -148,13 +165,21 @@ jobs:
name: test (Python ${{ matrix.python-version }})
runs-on: ubuntu-latest
needs: dependency-locks
if: github.event_name == 'push' || github.event_name == 'merge_group' || github.event.pull_request.head.repo.fork
if: >-
!cancelled()
&& (github.event_name == 'push' || github.event_name == 'merge_group' || github.event.pull_request.head.repo.fork)
strategy:
fail-fast: false
matrix:
# Per-PR coverage protects both ends of the support window.
python-version: ["3.10", "3.14"]
steps:
- name: Require fresh dependency locks
if: needs.dependency-locks.result != 'success'
run: |
echo 'Refuse to run without verified dependency locks.' >&2
exit 1

- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
persist-credentials: false
Expand Down Expand Up @@ -185,8 +210,16 @@ jobs:
name: test (HTTPX2)
runs-on: ubuntu-latest
needs: dependency-locks
if: github.event_name == 'push' || github.event_name == 'merge_group' || github.event.pull_request.head.repo.fork
if: >-
!cancelled()
&& (github.event_name == 'push' || github.event_name == 'merge_group' || github.event.pull_request.head.repo.fork)
steps:
- name: Require fresh dependency locks
if: needs.dependency-locks.result != 'success'
run: |
echo 'Refuse to run without verified dependency locks.' >&2
exit 1

- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
persist-credentials: false
Expand Down
13 changes: 13 additions & 0 deletions tests/test_uv_workflows.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1005,6 +1005,19 @@ def test_untrusted_provenance_leaves_no_dependency_install_reachable(tmp_path: P
} == installers


def test_required_checks_fail_when_dependency_provenance_fails() -> None:
jobs = dependency_workflow_jobs()
for name in ("lint", "build", "test", "test-httpx2"):
job = jobs[name]
assert re.search(r"^ needs:\s*dependency-locks\s*$", job, re.MULTILINE)
assert re.search(r"^ if: >-\n !cancelled\(\)\n", job, re.MULTILINE)

guard = job.split(" steps:\n", 1)[1].split("\n\n", 1)[0]
assert "if: needs.dependency-locks.result != 'success'" in guard
assert "exit 1" in guard
assert "uses:" not in guard


def test_scheduled_compatibility_keeps_dependency_provenance_gate() -> None:
jobs = dependency_workflow_jobs()
assert not re.search(r"^ if:.*schedule", jobs["dependency-locks"], re.MULTILINE)
Expand Down