Repository navigation
chore: update generated-code verification and preserve SDK helpers - #4186
Conversation
Castiron-Internal-PR: openai/openai-python-internal#354 Castiron-Source-SHA: 8a7d93e1f9b41bf88d48280f7917b2850f9b1f14 Castiron-Public-Base-SHA: 06dbb5d
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
jbeckwith-oai
changed the title
Castiron custom codeEvaluated main: Trusted main policy: ✅ No new custom-code files detected. 0 mixed files remain; 0 existing customizations changed. Compared A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 40420935477 --repo openai/openai-python \
--name castiron-custom-code-40420935477-1 --dir /tmp/castiron-custom-code-40420935477-1
git apply --stat /tmp/castiron-custom-code-40420935477-1/custom-code.patch
cat /tmp/castiron-custom-code-40420935477-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin 06dbb5d019d7b6870b5898bf5df579ca60b61d28 9f03955d858fed3f056c1bbf297b27dc5ee575a7
python3 scripts/castiron/custom_code_report.py report \
--base 06dbb5d019d7b6870b5898bf5df579ca60b61d28 \
--head 9f03955d858fed3f056c1bbf297b27dc5ee575a7 --target-branch main --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-9f03955d858f
cat /tmp/castiron-custom-code-9f03955d858f/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| import json | ||
| import subprocess | ||
| import sys | ||
| import unittest |
Summary
Updates generated-code verification and records the incremental transition to ordinary compiler templates while preserving existing Chat, streaming, and chunked-upload interfaces.
Most of the diff is generated ownership-reporting tooling, its workflows, and regression tests, including moving existing tests into separate modules. The transition document distinguishes the current zero mixed-file baseline from the remaining compiler cleanup.
The only SDK source change is nested-query filtering in the private WebSocket fallback in both clients. Current resource adapters and their inherited query helper are unchanged. Public signatures, types, dependencies, and runtime helper files are unchanged.
Validation
Hosted checks and required reviews must pass on this public PR before merging.