Skip to content

fix(examples): detect incomplete WebSocket responses - #4187

Open
markstuart-oai wants to merge 2 commits into
mainfrom
markstuart/websocket-audit-examples-20261026
Open

markstuart-oai wants to merge 2 commits into
mainfrom
markstuart/websocket-audit-examples-20261026

Conversation

@markstuart-oai

@markstuart-oai markstuart-oai commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Summary

The Realtime README, multi-agent Responses sample and Live transcript sample report errors and early closure. The Azure Realtime CLI also rejects unsuccessful terminal responses. It closes its credential, client and connection on normal and error paths.

Verification

  • 18 local WebSocket success and failure cases passed for the README, multi-agent and Live samples.
  • Six Azure cases passed against this SDK: completion, protocol error, early close, failed, cancelled and incomplete responses.
  • Azure tests use the real Identity provider with local token and TLS WebSocket fixtures. No Azure cloud service was contacted.
  • Pinned Ruff format/lint, Python 3.10 execution and unchanged custom-code budget guards passed. Generated code and generation metadata are unchanged.

@github-actions

github-actions Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Castiron custom code

Evaluated main: a3f430241c4a2e3e25bf79cc7d0148e51795a292.

Trusted main policy: a3f430241c4a2e3e25bf79cc7d0148e51795a292.

✅ No new custom-code files detected.

0 mixed files remain; 0 existing customizations changed.

Compared a3f430241c4a → 24c4e56455b8. Generated baselines verified.

A changed generated baseline means this report cannot reliably identify which handwritten lines changed.

Inspect the custom-code diff

Download the exact patch produced by this run (requires repository access):

gh run download 40444826529 --repo openai/openai-python \
  --name castiron-custom-code-40444826529-1 --dir /tmp/castiron-custom-code-40444826529-1
git apply --stat /tmp/castiron-custom-code-40444826529-1/custom-code.patch
cat /tmp/castiron-custom-code-40444826529-1/custom-code.patch

Or reproduce it from an SDK checkout containing the vendored reporter:

git fetch --no-tags origin a3f430241c4a2e3e25bf79cc7d0148e51795a292 24c4e56455b8337d99af943dbd1edc7ffd9ca810
python3 scripts/castiron/custom_code_report.py report \
  --base a3f430241c4a2e3e25bf79cc7d0148e51795a292 \
  --head 24c4e56455b8337d99af943dbd1edc7ffd9ca810 --target-branch main --fetch --require-head-hash --public \
  --out /tmp/castiron-custom-code-24c4e56455b8
cat /tmp/castiron-custom-code-24c4e56455b8/custom-code.patch

This is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR.

Full report and patch

@markstuart-oai
markstuart-oai marked this pull request as ready for review October 27, 2026 17:50
@markstuart-oai
markstuart-oai requested a review from a team as a code owner October 27, 2026 17:50
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-27T17:52:24.085365Z 24c4e56 Draft marked ready
🔒 Security Review ✅ Completed 2026-10-27T17:52:35.104804Z 24c4e56 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant