Skip to content

chore(api): record completed generated-code separation - #4190

Merged
jbeckwith-oai merged 1 commit into
mainfrom
castiron/promotions/pr-355
Oct 27, 2026
Merged

jbeckwith-oai merged 1 commit into
mainfrom
castiron/promotions/pr-355

Conversation

@jbeckwith-oai

Copy link
Copy Markdown
Contributor

Summary

Records the completed separation of generated SDK files and handwritten code. SDK code, public interfaces, and runtime behavior are unchanged.

Changes

  • Update generation metadata for the completed transition.
  • Update the transition plan and inventory with final validation results.
  • Retain the enforced zero-line customization budget.

Validation

  • Generated output matches the existing SDK across all 2,029 paths, including file modes.
  • 914 renderer tests and compiler lint passed.
  • Documentation formatting and inventory validation passed.

Castiron-Internal-PR: openai/openai-python-internal#355
Castiron-Source-SHA: ca143874a707d772e76d929e26d16eab5890baad
Castiron-Public-Base-SHA: 3596d18
@jbeckwith-oai
jbeckwith-oai requested a review from a team as a code owner October 27, 2026 06:31
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-27T06:32:28.958004Z 398dfbd PR opened
🔒 Security Review ✅ Completed 2026-10-27T06:32:56.685965Z 398dfbd PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown
Contributor

Castiron custom code

Evaluated main: 3596d18f05b63081fd64c6da82b515293afb98c6.

Trusted main policy: 3596d18f05b63081fd64c6da82b515293afb98c6.

✅ No new custom-code files detected.

0 mixed files remain; 0 existing customizations changed.

Compared 3596d18f05b6 → 398dfbd515fb. Generated baselines verified.

A changed generated baseline means this report cannot reliably identify which handwritten lines changed.

Inspect the custom-code diff

Download the exact patch produced by this run (requires repository access):

gh run download 40461710446 --repo openai/openai-python \
  --name castiron-custom-code-40461710446-1 --dir /tmp/castiron-custom-code-40461710446-1
git apply --stat /tmp/castiron-custom-code-40461710446-1/custom-code.patch
cat /tmp/castiron-custom-code-40461710446-1/custom-code.patch

Or reproduce it from an SDK checkout containing the vendored reporter:

git fetch --no-tags origin 3596d18f05b63081fd64c6da82b515293afb98c6 398dfbd515fb0608c6ae26c1418b19f356006f8f
python3 scripts/castiron/custom_code_report.py report \
  --base 3596d18f05b63081fd64c6da82b515293afb98c6 \
  --head 398dfbd515fb0608c6ae26c1418b19f356006f8f --target-branch main --fetch --require-head-hash --public \
  --out /tmp/castiron-custom-code-398dfbd515fb
cat /tmp/castiron-custom-code-398dfbd515fb/custom-code.patch

This is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR.

Full report and patch

@markstuart-oai markstuart-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. The diff is limited to generation metadata and two transition documents. The previous and new public generated checkpoints have identical Git trees. The strict zero-line policy and SDK source are unchanged.

The inventory's 41 former mixed files match the pinned baseline's hashes and line counts, totaling 40,356 physical lines. The recorded modes match the 2,028-entry generated manifest. Historical measurements remain intact and are clearly separated from the current status. No blocking findings.

Source-only review: I did not run candidate tests, builds or generation. The compiler tests and legacy/native qualification remain author-reported. Hosted CI and the required human review remain separate gates.

Reviewed head: 398dfbd515fb0608c6ae26c1418b19f356006f8f; base: 3596d18f05b63081fd64c6da82b515293afb98c6.

@jbeckwith-oai
jbeckwith-oai added this pull request to the merge queue Oct 27, 2026
Merged via the queue into main with commit d7ab5ee Oct 27, 2026
36 checks passed
@jbeckwith-oai
jbeckwith-oai deleted the castiron/promotions/pr-355 branch October 27, 2026 06:43
@openai-sdks openai-sdks Bot mentioned this pull request Oct 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants