Skip to content

Fix missing favorite flag on opensearch hits - #3252

Merged
micbar merged 1 commit into
opencloud-eu:mainfrom
aduffeck:fix-favorite-flag
Aug 6, 2026
Merged

Fix missing favorite flag on opensearch hits#3252
micbar merged 1 commit into
opencloud-eu:mainfrom
aduffeck:fix-favorite-flag

Conversation

@aduffeck

@aduffeck aduffeck commented Aug 5, 2026

Copy link
Copy Markdown
Member

Fix favorites Flag in search response.

@codacy-production

codacy-production Bot commented Aug 5, 2026

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

🟢 Coverage 100.00% diff coverage · +0.00% coverage variation

Metric Results
Coverage variation +0.00% coverage variation (-1.00%)
Diff coverage 100.00% diff coverage

View coverage diff in Codacy

Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (76ff13b) 84009 19267 22.93%
Head commit (2142894) 84010 (+1) 19269 (+2) 22.94% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#3252) 6 6 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@micbar
micbar requested a review from fschade August 5, 2026 16:46
@micbar micbar added the Priority:p2-high High priority label Aug 5, 2026

@dschmidt dschmidt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

During review I stumbled upon etags missing in the search results as well. Maybe worth filing an issue to not forget about it...

@micbar
micbar merged commit 466c3c8 into opencloud-eu:main Aug 6, 2026
64 of 65 checks passed
@aduffeck
aduffeck deleted the fix-favorite-flag branch August 6, 2026 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants