Repository navigation
Conversation
Up to standards ✅🟢 Issues
|
v-scharf
marked this pull request as draft
November 2, 2026 13:07
Requests that carry a guest session cookie together with other credentials (bearer token, basic auth, public link, signed URL) must be authenticated with those credentials, or rejected with 401 if they are invalid, and never fall back to the guest. Also covers what the web client does in a guest session: downloads via the signed oc:downloadURL and TUS uploads with an unusable Authorization header. Assisted-by: Claude Code:claude-opus-5-5
v-scharf
force-pushed
the
test/guest-session-other-credentials
branch
from
November 12, 2026 14:32
f996b50 to
2ee5010
Compare
v-scharf
marked this pull request as ready for review
November 12, 2026 14:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related #3857
Adds acceptance tests that a guest session cookie never overrides other credentials sent with the same request.