Skip to content

Fix Reva config to also validate OC_CACHE_* tls settings and fix the disable_persistence key - #3913

Open
Pflum wants to merge 1 commit into
opencloud-eu:mainfrom
Pflum:fix-revaconfig
Open

Pflum wants to merge 1 commit into
opencloud-eu:mainfrom
Pflum:fix-revaconfig

Conversation

@Pflum

@Pflum Pflum commented Nov 6, 2026

Copy link
Copy Markdown

Description

The Opencloud not use the tls config for the nats connection from reva so this results in a error in the browser log when select a space for example:

{"error":{"code":"generalException","innererror":{"date":"2026-11-06T08:44:36Z","request-id":"8e88aed3-9a2c-4d0c-a513-5e9b9d6da845"},"message":"gateway could not call ListStorageSpaces:Failed to connect to NATS Server: nats: tls error: tls: failed to verify certificate: x509: certificate signed by unknown authority"}}

Motivation and Context

We use the opencloud with a tls enabled nats but the certificate is a internal ca. I set following env vars to the right settings, the most services are running fine with these:
OC_CACHE_ENABLE_TLS
OC_CACHE_TLS_INSECURE
OC_CACHE_TLS_ROOT_CA_CERTIFICATE

How Has This Been Tested?

  • I setup the opencloud in kubernetes with a internal nats ca

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation added

@codacy-production

codacy-production Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Coverage 0.00% diff coverage · -0.01% coverage variation

Metric Results
Coverage variation ✅ -0.01% coverage variation (-1.00%)
Diff coverage ✅ 0.00% diff coverage

View coverage diff in Codacy

Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (2eb513b) 93435 26771 28.65%
Head commit (7dbce1b) 93438 (+3) 26759 (-12) 28.64% (-0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#3913) 11 0 0.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@micbar
micbar marked this pull request as ready for review November 13, 2026 07:55
@butonic
butonic enabled auto-merge November 13, 2026 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants