Repository navigation
Conversation
Pulls in the ListPublicShares change that answers with an OK status and no shares when the share manager reports an AlreadyExists error, and the errtypes.ERR_ALREADY_EXISTS prefix the graph service needs to detect that error. reva is replaced with the PR head in the butonic fork until the reva PR is merged. Assisted-by: Claude Code:claude-opus-5-5 Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Add specs for ListPermissions when listing the public shares fails: an already exists error still returns the other permissions, any other error is returned. The reva share provider already answers already exists errors with an OK status and no shares, so the graph check is a defensive measure that only kicks in if such a status reaches us some other way. Assisted-by: Claude Code:claude-opus-5-5 Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 4 |
🟢 Coverage 100.00% diff coverage · +0.00% coverage variation
Metric Results Coverage variation ✅ +0.00% coverage variation (-1.00%) Diff coverage ✅ 100.00% diff coverage Coverage variation details
Coverable lines Covered lines Coverage Common ancestor commit (0da2e89) 93867 27079 28.85% Head commit (6655992) 93871 (+4) 27083 (+4) 28.85% (+0.00%) Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch:
<coverage of head commit> - <coverage of common ancestor commit>Diff coverage details
Coverable lines Covered lines Diff coverage Pull request (#3974) 5 5 100.00% Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified:
<covered lines added or modified>/<coverable lines added or modified> * 100%
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
The public share listing fix is merged into reva workpackages, so we drop the replace with the butonic fork. This also pulls in the managed spaces change that was merged before it. Assisted-by: Claude Code:claude-opus-5-5 Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
butonic
marked this pull request as ready for review
November 13, 2026 07:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We now still return the user and space permissions from ListPermissions when listing the public shares fails with an already exists error, instead of failing the whole request. Any other error is still returned.
The reva change in opencloud-eu/reva#996 (merged into reva workpackages) already answers that case with an OK status and no shares, so the graph check is a defensive measure that only kicks in if such a status reaches us some other way.
reva is bumped to workpackages 67131be3d, which also brings in the managed spaces change. Stacked on #3839, because reva
workpackagesneeds the upload coordinator changes.Review commit by commit.
Assisted by Claude Code (claude-opus-5-5): it ported the change, bumped reva, wrote the specs and this description.