Skip to content

Show vault breadcrumb icons from breadcrumb item props - #3367

Open
AlexAndBear wants to merge 2 commits into
mainfrom
feat/vault-breadcrumb-icons-3325
Open

AlexAndBear wants to merge 2 commits into
mainfrom
feat/vault-breadcrumb-icons-3325

Conversation

@AlexAndBear

Copy link
Copy Markdown
Member

Description

  • Render breadcrumb item icons from OcBreadcrumb items prop for links, buttons, static labels, and the truncation menu.
  • Keep vault icon rendering in files breadcrumbs scoped to vault resources via vault claim root matching.
  • Preserve icon when the last breadcrumb is converted to a click action via concatBreadcrumbs.

Related Issue

How Has This Been Tested?

  • test environment: local macOS workspace with pnpm + Vitest
  • test case 1: pnpm test:unit --run packages/design-system/src/components/OcBreadcrumb/OcBreadcrumb.spec.ts
  • test case 2: pnpm test:unit --run packages/web-app-files/tests/unit/views/spaces/GenericSpace.spec.ts
  • test case 3: pnpm test:unit --run packages/web-pkg/tests/unit/composables/breadcrumbs/useBreadcrumbsFromPath.spec.ts packages/web-pkg/tests/unit/helpers/breadcrumbs.spec.ts
  • test case 4: pnpm eslint packages/design-system/src/components/OcBreadcrumb/OcBreadcrumb.vue packages/design-system/src/components/OcBreadcrumb/OcBreadcrumb.spec.ts packages/web-app-files/src/views/spaces/GenericSpace.vue packages/web-app-files/tests/unit/views/spaces/GenericSpace.spec.ts packages/web-pkg/src/composables/breadcrumbs/useBreadcrumbsFromPath.ts packages/web-pkg/src/helpers/breadcrumbs.ts packages/web-pkg/tests/unit/composables/breadcrumbs/useBreadcrumbsFromPath.spec.ts packages/web-pkg/tests/unit/helpers/breadcrumbs.spec.ts

Types of changes

  • Bugfix
  • Enhancement (a change that doesn't break existing code or deployments)
  • Breaking change (a modification that affects current functionality)
  • Technical debt (addressing code that needs refactoring or improvements)
  • Tests (adding or improving tests)
  • Documentation (updates or additions to documentation)
  • Maintenance (like dependency updates or tooling adjustments)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show that a vault is a special folder / has limited capabilities

1 participant