fix(web-pkg): keep full folder names when file extensions are hidden - #3369
Merged
Merged
Conversation
AlexAndBear
requested review from
JammingBen
and
a lite review from Copilot
September 14, 2026 20:50
Member
Author
|
@JammingBen @kulmann IHMO this is 'cirticial' and shouldn't be implemented that way, in the first place 🤷♀️ |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved blocking issues were identified.
Pull request overview
Fixes resource-name rendering so extension hiding applies only to files, preserving dotted folder names and avoiding trailing dots for extensionless files.
Changes:
- Restricts extension logic to file resources.
- Preserves full dotted folder names.
- Adds targeted unit tests.
File summaries
| File | Summary |
|---|---|
packages/web-pkg/tests/unit/components/FilesList/ResourceName.spec.ts |
Adds regression tests for dotted folders and extensionless files. |
packages/web-pkg/src/components/FilesList/ResourceName.vue |
Restricts extension rendering to files. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
kulmann
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This bugfix ensures that the "Show file extensions" preference only affects files and never truncates folder names.
Why this is important:
Examples where full folder names must stay visible:
20.01.20262026.01.ReleaseQ4.2026.ArchiveProject.Alpha.v2Customer.ACME.2026Invoices.2026.01Technical changes:
type === 'file'inResourceName.vue.README, notREADME.).ResourceName.spec.ts.Related Issue
How Has This Been Tested?
pnpm test:unit --run packages/web-pkg/tests/unit/components/FilesList/ResourceName.spec.tspnpm test:unit --run packages/web-pkg/tests/unit/components/FilesList/ResourceTable.spec.tsTypes of changes