Repository navigation
Conversation
The unknown annotation case keeps the default process of the generator, /runtimetest, but misc_props only unpacks the root filesystem into its bundle and never copies runtimetest there. A runtime that reports a failed entrypoint from start therefore fails the case, although the annotation was accepted; one that only notices later passes it. Run true like the unknown property case does, so that the case tests the annotation alone. Signed-off-by: Daniel Golle <daniel@makrotopia.org>
dangowrt
marked this pull request as ready for review
October 20, 2026 19:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The unknown annotation case of
misc_propskeeps the generator's default process,/runtimetest, but the test only unpacks the root filesystem into its bundle and never copiesruntimetestthere. A runtime that reports a failed entrypoint fromstarttherefore fails the case even though it accepted the annotation, while a runtime that only notices later passes it.This runs
true, as the unknown property case already does, so the case tests the annotation alone.