Repository navigation
Conversation
Both blkio tests name device 8:0 and assume that /dev/sda exists. On a host whose disks are virtio, NVMe or MMC there is no 8:0, the kernel refuses an io.max entry for it, and a runtime that reports the failed write cannot create the container, so the tests fail without having looked at the runtime's blkio handling. Take the device number of a whole disk from /sys/block instead, preferring one backed by hardware. Signed-off-by: Daniel Golle <daniel@makrotopia.org>
dangowrt
marked this pull request as ready for review
October 20, 2026 19:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
linux_cgroups_blkioandlinux_cgroups_relative_blkioname block device 8:0 and assume/dev/sdaexists. On a host whose disks are virtio, NVMe or MMC there is no 8:0, the kernel rejects theio.maxentry for it, and a runtime that reports the failed write cannot create the container, so both tests fail without looking at the runtime's blkio handling.This adds
util.GetBlockDevice(), which takes the device number of a whole disk from/sys/block(only whole disks are listed there), preferring one backed by hardware over loop and RAM disks, and uses it in both tests.