Skip to content

Version 1.20260810.0 - #549

Merged
agarny merged 5 commits into
opencor:mainfrom
agarny:cleaning-up
Aug 9, 2026
Merged

Version 1.20260810.0#549
agarny merged 5 commits into
opencor:mainfrom
agarny:cleaning-up

Conversation

@agarny

@agarny agarny commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI lite review requested due to automatic review settings August 9, 2026 14:27

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR bumps the application/renderer version to 1.20260810.0, updates build tooling (esbuild), and refines desktop UI interactions—most notably adding tab drag-reordering support while avoiding interference with file drag-and-drop.

Changes:

  • Add internal drag-and-drop tab reordering and a scrollable tab bar in ContentsComponent.vue.
  • Prevent OpenCOR’s drag-enter overlay from reacting to internal (non-file) drags.
  • Bump versions and refresh lockfiles (including esbuild to ^0.28.2).

Reviewed changes

Copilot reviewed 5 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/renderer/src/components/OpenCOR.vue Ignore non-file dragenter events to prevent UI overlay during internal drags.
src/renderer/src/components/MainMenu.vue Update update-notification button styling; adjust scoped selectors for PrimeVue menubar styling.
src/renderer/src/components/ContentsComponent.vue Replace PrimeVue Tabs UI with a custom scrollable tab bar + drag-reorder logic and indicator.
src/renderer/package.json Bump renderer package version and esbuild dependency.
src/renderer/bun.lock Lockfile updates reflecting renderer dependency bumps.
package.json Bump root app version and esbuild dependency.
bun.lock Lockfile updates reflecting root dependency bumps.
Suppressed comments (1)

src/renderer/src/components/MainMenu.vue:246

  • In a scoped style block, using :deep() only on .p-menubar-root-list means the subsequent selectors (>.p-menubar-item, etc.) still get scoped attributes and won’t match PrimeVue’s internal DOM. Wrap the whole selector in :deep(...) so the submenu icon rule actually applies.
.p-menubar
  > :deep(.p-menubar-root-list)
  > .p-menubar-item
  > .p-menubar-item-content
  > .p-menubar-item-link
  .p-menubar-submenu-icon {

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/renderer/src/components/ContentsComponent.vue
Comment thread src/renderer/src/components/ContentsComponent.vue Outdated
Comment thread src/renderer/src/components/ContentsComponent.vue

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 7 changed files in this pull request and generated no new comments.

Suppressed comments (1)

src/renderer/src/components/ContentsComponent.vue:25

  • The custom file-tab elements are plain
    nodes with click handlers and draggable behavior, which removes the keyboard/ARIA semantics that PrimeVue Tabs previously provided. This is an accessibility regression (tabs are not focusable by default, and screen readers won’t get tablist/tab relationships). Consider adding proper tab semantics (role/tablist, role/tab, aria-selected) and keyboard activation at minimum.
    <div v-show="fileTabs.length" ref="fileTabBarRef" class="file-tab-bar shrink-0 border-b border-b-primary flex overflow-x-auto"
      @wheel.prevent="onWheel"
    >
      <div v-show="dropIndicatorLeft !== null" class="file-tab-drop-indicator"
        :style="{ left: `${dropIndicatorLeft}px` }"

@agarny
agarny merged commit 24f3eef into opencor:main Aug 9, 2026
17 of 18 checks passed
@agarny
agarny deleted the cleaning-up branch August 9, 2026 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants