Version 1.20260810.0 - #549
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR bumps the application/renderer version to 1.20260810.0, updates build tooling (esbuild), and refines desktop UI interactions—most notably adding tab drag-reordering support while avoiding interference with file drag-and-drop.
Changes:
- Add internal drag-and-drop tab reordering and a scrollable tab bar in
ContentsComponent.vue. - Prevent OpenCOR’s drag-enter overlay from reacting to internal (non-file) drags.
- Bump versions and refresh lockfiles (including
esbuildto^0.28.2).
Reviewed changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/renderer/src/components/OpenCOR.vue | Ignore non-file dragenter events to prevent UI overlay during internal drags. |
| src/renderer/src/components/MainMenu.vue | Update update-notification button styling; adjust scoped selectors for PrimeVue menubar styling. |
| src/renderer/src/components/ContentsComponent.vue | Replace PrimeVue Tabs UI with a custom scrollable tab bar + drag-reorder logic and indicator. |
| src/renderer/package.json | Bump renderer package version and esbuild dependency. |
| src/renderer/bun.lock | Lockfile updates reflecting renderer dependency bumps. |
| package.json | Bump root app version and esbuild dependency. |
| bun.lock | Lockfile updates reflecting root dependency bumps. |
Suppressed comments (1)
src/renderer/src/components/MainMenu.vue:246
- In a scoped style block, using :deep() only on .p-menubar-root-list means the subsequent selectors (>.p-menubar-item, etc.) still get scoped attributes and won’t match PrimeVue’s internal DOM. Wrap the whole selector in :deep(...) so the submenu icon rule actually applies.
.p-menubar
> :deep(.p-menubar-root-list)
> .p-menubar-item
> .p-menubar-item-content
> .p-menubar-item-link
.p-menubar-submenu-icon {
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 7 changed files in this pull request and generated no new comments.
Suppressed comments (1)
src/renderer/src/components/ContentsComponent.vue:25
- The custom file-tab elements are plain nodes with click handlers and draggable behavior, which removes the keyboard/ARIA semantics that PrimeVue Tabs previously provided. This is an accessibility regression (tabs are not focusable by default, and screen readers won’t get tablist/tab relationships). Consider adding proper tab semantics (role/tablist, role/tab, aria-selected) and keyboard activation at minimum.
<div v-show="fileTabs.length" ref="fileTabBarRef" class="file-tab-bar shrink-0 border-b border-b-primary flex overflow-x-auto"
@wheel.prevent="onWheel"
>
<div v-show="dropIndicatorLeft !== null" class="file-tab-drop-indicator"
:style="{ left: `${dropIndicatorLeft}px` }"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.