Skip to content

Version 1.20260811.0 - #550

Merged
agarny merged 6 commits into
opencor:mainfrom
agarny:cleaning-up
Aug 11, 2026
Merged

Version 1.20260811.0#550
agarny merged 6 commits into
opencor:mainfrom
agarny:cleaning-up

Conversation

@agarny

@agarny agarny commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI lite review requested due to automatic review settings August 10, 2026 13:49

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the project’s version to 1.20260811.0 and adjusts the renderer HTML’s base page styling to better fit a full-viewport app shell.

Changes:

  • Bumped root package version to 1.20260811.0.
  • Bumped renderer package version to 1.20260811.0.
  • Set body { margin: 0; overflow: hidden; } in the renderer index.html to remove default page margins and prevent body scrolling.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
package.json Version bump to 1.20260811.0.
src/renderer/package.json Renderer package version bump to 1.20260811.0.
src/renderer/index.html Removes default body margin and disables body scrolling for a fixed-viewport renderer shell.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

agarny added 5 commits August 11, 2026 11:47
In the Web app, if you use the mouse wheel, then it will look like we are trying to scroll up/down the Web app, which is clearly not what we want.
We should only register views that can actually be used as such.
This means that if a view doesn't support a given file type, then it should say so.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 11 out of 13 changed files in this pull request and generated no new comments.

Suppressed comments (2)

src/renderer/src/components/views/SimulationExperimentInteractiveView.vue:1034

  • reinstantiateInstance() always calls instance.task(0) immediately after instantiation. If the reinstantiated instance has issues (e.g. due to model changes), task(0) may be invalid/throw (see SedInstance.task() calling into the WASM instance task). Update the function to refresh the tracked issues and only create a task when there are no issues.
const reinstantiateInstance = (): locApi.SedInstance => {
  instance = document.instantiate();
  instanceTask = instance.task(0);

  return instance;
};

src/renderer/src/components/views/SimulationExperimentInteractiveView.vue:240

  • issues is computed once as a plain array, but instance can be reassigned later in reinstantiateInstance(). That means the top-level IssuesView can become stale (still showing old issues, or none) after reinstantiation. Make issues a ref so it can be updated when the instance changes, and base instanceTask on issues.value.length.

This issue also appears on line 1029 of the same file.

const documentIssues = document.issues();
const isDocumentValid = documentIssues.length === 0;
const uniformTimeCourse = isDocumentValid ? (document.simulation(0) as locApi.SedUniformTimeCourse) : null;
const cvode = uniformTimeCourse?.cvode() ?? null;
let instance = isDocumentValid ? document.instantiate() : null;
const issues = documentIssues.length > 0 ? documentIssues : (instance?.issues() ?? []);
let instanceTask = issues.length > 0 ? null : (instance?.task(0) ?? null);

@agarny
agarny merged commit f884d7b into opencor:main Aug 11, 2026
9 checks passed
@agarny
agarny deleted the cleaning-up branch August 11, 2026 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants