Version 1.20260811.0 - #550
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the project’s version to 1.20260811.0 and adjusts the renderer HTML’s base page styling to better fit a full-viewport app shell.
Changes:
- Bumped root package version to
1.20260811.0. - Bumped renderer package version to
1.20260811.0. - Set
body { margin: 0; overflow: hidden; }in the rendererindex.htmlto remove default page margins and prevent body scrolling.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Version bump to 1.20260811.0. |
| src/renderer/package.json | Renderer package version bump to 1.20260811.0. |
| src/renderer/index.html | Removes default body margin and disables body scrolling for a fixed-viewport renderer shell. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
In the Web app, if you use the mouse wheel, then it will look like we are trying to scroll up/down the Web app, which is clearly not what we want.
We should only register views that can actually be used as such.
This means that if a view doesn't support a given file type, then it should say so.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 11 out of 13 changed files in this pull request and generated no new comments.
Suppressed comments (2)
src/renderer/src/components/views/SimulationExperimentInteractiveView.vue:1034
reinstantiateInstance()always callsinstance.task(0)immediately after instantiation. If the reinstantiated instance has issues (e.g. due to model changes),task(0)may be invalid/throw (seeSedInstance.task()calling into the WASM instance task). Update the function to refresh the tracked issues and only create a task when there are no issues.
const reinstantiateInstance = (): locApi.SedInstance => {
instance = document.instantiate();
instanceTask = instance.task(0);
return instance;
};
src/renderer/src/components/views/SimulationExperimentInteractiveView.vue:240
issuesis computed once as a plain array, butinstancecan be reassigned later inreinstantiateInstance(). That means the top-level IssuesView can become stale (still showing old issues, or none) after reinstantiation. Makeissuesa ref so it can be updated when the instance changes, and baseinstanceTaskonissues.value.length.
This issue also appears on line 1029 of the same file.
const documentIssues = document.issues();
const isDocumentValid = documentIssues.length === 0;
const uniformTimeCourse = isDocumentValid ? (document.simulation(0) as locApi.SedUniformTimeCourse) : null;
const cvode = uniformTimeCourse?.cvode() ?? null;
let instance = isDocumentValid ? document.instantiate() : null;
const issues = documentIssues.length > 0 ? documentIssues : (instance?.issues() ?? []);
let instanceTask = issues.length > 0 ? null : (instance?.task(0) ?? null);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.