feat: replace enterprise support view imports with filter calls - #39076
Draft
brobro10000 wants to merge 1 commit into
Draft
feat: replace enterprise support view imports with filter calls#39076brobro10000 wants to merge 1 commit into
brobro10000 wants to merge 1 commit into
Conversation
ENT-11574 Swaps the direct openedx.features.enterprise_support imports in the support contact-us and enrollment views for calls to the new SupportContactContextRequested / SupportEnrollmentDataRequested openedx-filters, and wires up OPEN_EDX_FILTERS_CONFIG for the two new filter types (edx-enterprise's pipeline steps). Tests now mock the filter call at the view layer; the enterprise-specific pipeline step behavior is covered by edx-enterprise's own test suite.
This was referenced Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ENT-11574
Swaps the direct
openedx.features.enterprise_supportimports in the support contact-us andenrollment views for calls to the new
SupportContactContextRequested/SupportEnrollmentDataRequestedopenedx-filters, and wires upOPEN_EDX_FILTERS_CONFIGforthe two new filter types (scoped to just these two entries —
OPEN_EDX_FILTERS_CONFIGdoesn'texist on
masteryet, and other filter areas from this same epic have their own separatein-flight branches/tickets).
Related PRs
Merge order (per the enterprise plugin ticket runbook)
This PR merges LAST, only after:
confirmed working.
Do not merge before that sequence completes.
Testing
Changed:
lms/djangoapps/support/tests/test_views.py— the enterprise-enrollment-data test nowmocks
SupportEnrollmentDataRequested.run_filterat the call site (the enterprise-specificpipeline-step behavior is covered by edx-enterprise's own test suite instead), and a new
ContactUsViewTestsclass verifies the contact-tag filter is wired correctly.Local devstack integration testing (with the openedx-filters, edx-enterprise, and edx-platform
branches checked out together) is required before any of these four PRs merge — see the handoff
prompt below for exact steps.