[BB-10699] Add configurable Qualtrics query params - #29
Conversation
|
Thanks for the pull request, @pkulkark! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #29 +/- ##
==========================================
+ Coverage 82.17% 82.68% +0.51%
==========================================
Files 48 48
Lines 1419 1461 +42
Branches 110 117 +7
==========================================
+ Hits 1166 1208 +42
+ Misses 221 220 -1
- Partials 32 33 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@pkulkark Code coverage has fallen under. Can you take a look? These changes are breaking from an operator perspective-- if someone has the Stanford especially will need to be notified, as they'll no longer be able to rely on the default university name to be their university name. I do think these changes are important and worth it, but I want to make sure these changes are documented in the release notes somewhere, so anyone using the block knows they need to set these settings. @kdmccormick I know these blocks aren't installed by default, so I'm not sure if the best place to put these is in the standard release notes, or if we should just include some notice of the breaking change in the README, and increment the major version number. Do you have any thoughts here? Right now this PR document the right settings to use, but not necessarily that someone NEEDS to set them when they hadn't previously. |
f65e7cf to
f1a1a57
Compare
|
@pkulkark I'm happy with these changes now. The CI passes, it works for me, the code looks good, and I can see the README at least talks about the fact these settings need to be set for user data to be sent over. So this is 👍 from me. There doesn't appear to be a need to manually bump any version-- the version is picked up from the SCM tag, so I think this is good to merge. However, I don't have merge rights. @farhan , it looks like you do. Would you be willing to merge and release this? Or is there anything else you'd need before doing so? I'd recommend a major version bump for this one based on this comment. I'm also curious about your thoughts re: documentation of the changes there. Thanks! |
|
Code review details: Note: Findings, by severity:
Verified fine: switching to |
@Kelketek thanks for the review, and @pkulkark for the PR. With PSR, the release type comes from the Conventional Commit prefixes, not a manual bump. The commits here are fyi @feanil @openedx/axim-aximprovements ^ |
BREAKING CHANGE: `param_name` now defaults to "" instead of "a" and is
no longer editable in Studio. Blocks that relied on the old default stop
sending `?a=<anonymous id>` until operators configure
`USER_QUERY_PARAMS: {"a": "anonymous_id"}`. `your_university` now
defaults to "" instead of "stanforduniversity"; blocks that relied on
that default need `DEFAULT_UNIVERSITY: "stanforduniversity"`. See the
Upgrading section of the Qualtrics Survey README.
f1a1a57 to
34029ee
Compare
|
@farhan Thanks. I've added a |
Description
This PR adds settings-based user query parameter support to the qualtricssurvey XBlock. It adds
extra_paramsas a per-block additional key-value query param field, preserves legacyparam_namecompatibility for existing blocks, and updates tests and documentation.Supporting Information
OpenCraft Internal Jira task: BB-10699
Testing Instructions
XBLOCK_SETTINGS["QualtricsSurvey"]settings as described in the README with the desired config values.