Document common function patterns and examples - #436
Conversation
This comment has been minimized.
This comment has been minimized.
dbdd46a to
d42b2a1
Compare
This comment has been minimized.
This comment has been minimized.
7865ffc to
4645b26
Compare
This comment has been minimized.
This comment has been minimized.
4645b26 to
dcc9c5c
Compare
This comment has been minimized.
This comment has been minimized.
dcc9c5c to
0316aa8
Compare
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Han Verstraete (OpenFaaS Ltd) <han@openfaas.com>
0316aa8 to
e9bdba0
Compare
This comment has been minimized.
This comment has been minimized.
| - Readiness checks for slow start-up: ./languages/python/examples/readiness.md | ||
| - Node: ./languages/node.md | ||
| - Go: ./languages/go.md | ||
| - Go: ./languages/go/index.md |
There was a problem hiding this comment.
Looks breaking.. same for Python?
Signed-off-by: Han Verstraete (OpenFaaS Ltd) <han@openfaas.com>
Signed-off-by: Han Verstraete (OpenFaaS Ltd) <han@openfaas.com>
Signed-off-by: Han Verstraete (OpenFaaS Ltd) <han@openfaas.com>
Signed-off-by: Han Verstraete (OpenFaaS Ltd) <han@openfaas.com>
AI Pull Request OverviewDisclaimer: This review was generated by automated AI and may contain errors. Do not trust its outputs without human verification. Summary
Approval rating (1-10)7/10. Useful documentation, but the build-breaking Go snippet and misleading fan-in setup steps should be fixed before merge. Summary per fileSummary per file
Overall AssessmentThe PR adds a substantial and relevant documentation section with a clear reader journey from overview to runnable examples. The main merge risks are not architectural; they are reproducibility defects in copied commands and code snippets. Fixing those should make the new section publishable. Detailed ReviewDetailed ReviewContent reviewFindingsMedium: Go director example will not compile because In import (
"context"
"encoding/json"
"net/http"
)Go rejects unused imports, so a reader copying this example into the generated Medium: Fan-in scaffolding commands create the function outside the expected stack layout In Make the setup match the rest of the workflow by scaffolding from the existing fan-out project root and appending to the current faas-cli template store pull golang-middleware
faas-cli new --lang golang-middleware fan-in \
--append stack.yaml --prefix ttl.sh/openfaas-examplesApply the same structure to the Python and Node.js tabs so the paths like Low: Director page uses an undefined Markdown reference link for In The example uses the public [ttl.sh](https://ttl.sh) registry.Additional content observationsThe overview page gives a clear entry point into the new pattern section, and the new navigation in The pattern pages have consistent structure: problem framing, scaffolding, implementation, configuration, deployment, and considerations. That makes the section easy to scan across languages. The content does not use front matter titles or excerpts, so title/excerpt fit is not applicable in the changed pages. The page headings and navigation labels are aligned with the article scope. AI agent details. |
Description
Document common function patterns and add examples for each pattern.
Motivation and Context
Provide a concise reference for common function patterns and demonstrate them with examples.
How Has This Been Tested?
Verified the pages render correctly and the examples have been tested end-to-end.
Types of changes
Checklist:
git commit -s