Repository navigation
Conversation
…ttributes OAuth2Client recorded fga-client.credentials.request with a hard-coded empty attributes map, so the metric had no host, status code or other attributes. Record it in exchangeToken with the attributes that HttpRequestAttempt collected for the token request. Fixes openfga#149 Fixes openfga#208 Signed-off-by: Srinivas Chippagiri <cvas22@gmail.com>
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 17 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
OAuth2Clientrecorded thefga-client.credentials.requestcounter with a hard-coded empty attributes map (#149, #208), so the metric had none of the configured attributes: no host, URL, method, status code or resend count.HttpRequestAttemptalready collects those attributes for the token request, but they never made it back togetAccessToken(), where the counter was recorded. The counter is now recorded inexchangeToken(), right after the token request succeeds, withattempt.getTelemetryAttributes(). As before, it's recorded once per successful exchange, and the attribute filtering from the telemetry configuration still applies inMetrics.Fixes #149
Fixes #208
Testing
New
credentialsRequestMetricHasTheTokenRequestAttributesinOAuth2ClientTest: it intercepts theMetricsinstance with Mockito'smockConstruction, exchanges a token, and checks thatcredentialsRequestis called once with the token request'shttp.host,http.request.methodandhttp.response.status_code. That avoids adding the OpenTelemetry SDK as a test dependency.I haven't run the Gradle build locally, so I'm relying on CI for compilation and the test run.