Repository navigation
Conversation
When the configuration had no telemetry configuration, the Metrics constructor set a new default one on it. A configuration shared with other code paths was thereby changed as a side effect. Fall back to a default telemetry configuration inside Metrics instead, and let Attributes.prepare take the telemetry configuration directly. Fixes openfga#292 Signed-off-by: Srinivas Chippagiri <cvas22@gmail.com>
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 15 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
Metricsconstructor set a newTelemetryConfigurationon theConfigurationpassed to it when it had none (#292). AConfigurationshared with other code paths was thereby modified as a side effect of creating metrics.Change:
Metricskeeps its own defaultTelemetryConfigurationand uses it whenever the configuration has none. It still reads the configuration on each call, so a telemetry configuration set later is picked up as before, but it never writes to it.Attributes.preparehas a new overload that takes theTelemetryConfiguration, whichMetricsuses with the resolved configuration. The existingprepare(attributes, metric, Configuration)delegates to it, so its behavior is unchanged.The metrics recorded are the same as before: with no telemetry configuration, the defaults apply, as they did when the constructor set them.
Fixes #292
Testing
Two new cases in
MetricsTest:Metricsand recording a metric leaves the configuration's telemetry configuration unchangednullI haven't run the Gradle build locally, so I'm relying on CI for compilation and the test run.