Skip to content

Don't create an empty addons.make for a project without addons (#297) #680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
danoli3 wants to merge 1 commit into from
Closed

Don't create an empty addons.make for a project without addons (#297) #680

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 8 additions & 10 deletions commandLine/src/projects/baseProject.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,16 +404,14 @@ bool baseProject::create(const fs::path & _path, string templateName){
}

bool baseProject::save(){
ofLog(OF_LOG_NOTICE) << "saving addons.make";

std::ofstream addonsMake(projectDir / "addons.make");
for (auto & a : addons) {
addonsMake << a.addonMakeName << std::endl;
// if (a.isLocalAddon) {
// addonsMake << fs::path(a.addonPath).generic_string() << std::endl;
// } else {
// addonsMake << a.name << std::endl;
// }
// no addons and no addons.make yet: don't create an empty one (#297).
// an existing one is still rewritten, so removing every addon clears it
if (addons.size() || fs::exists(projectDir / "addons.make")) {
ofLog(OF_LOG_NOTICE) << "saving addons.make";
std::ofstream addonsMake(projectDir / "addons.make");
for (auto & a : addons) {
addonsMake << a.addonMakeName << std::endl;
}
}

//save out params which the PG knows about to config.make
Expand Down
Loading