Conversation
piptouque
force-pushed
the
fix_server_error_query_params
branch
5 times, most recently
from
September 18, 2026 12:02
8392668 to
d849165
Compare
Ralph should not return 500 errors for malformed IRI and `agent` query parameters.
piptouque
force-pushed
the
fix_server_error_query_params
branch
from
September 18, 2026 14:01
d849165 to
d8f6ac8
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Ralph should not return 500 errors for malformed IRI query parameters, and validation errors on
agent.You may check this by:
verboractivity,agent.Proposal
Per the specs,
the server should return 400 (Bad Request) errors.
But to align with the rest of the parameters, we use
the default FastAPI validation of IRI (returns 422 - Unprocessable Entity).
IRIStrscalar type deriving from string to use in validationsverbandactivitytypes toIRIStrinstead ofstrin/statementsGETagenttype toJson[BaseXapiAgent]instead of plainJsonin/statementsGET