Repository navigation
Conversation
w-goog
force-pushed
the
codegen/rfc8414-optional-metadata-a
branch
from
October 21, 2026 22:03
64bc32c to
c1f51bd
Compare
w-goog
changed the title
…ional-metadata-a # Conflicts: # CHANGELOG.md
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is the first half of fixing #380.
OIDServiceDiscoverynow checks that every URL-valued field that's present is a string. Only the nonnull ones (issuer,authorization_endpoint,token_endpoint,jwks_uri) have to parse - a sloppy optional URL just reads asnil.nullor a non-string value fails withOIDErrorCodeInvalidDiscoveryDocumentinstead of raising an exception.pendingTest...cases!! plus one for the non-string case and one for the sloppy-optional case.RFC 8414 documents that omit
jwks_uri& co. still fail validation. The right fix is to mark those propertiesnullable, but that'd be source-breaking, so we'll do that in the 4.0 release.Note for reviewers: I narrowed the URL check, since a provider's sloppy
op_tos_urishouldn't block a sign-in. The present URL fields must be strings (or the getters get sad), but only the nonnull ones have to parse. The nullable getters already returnnilfor a bad URL.