Skip to content

Add download_jeff for official JEFF 3.3 and 4.0 libraries - #41

Merged
shimwell merged 3 commits into
mainfrom
jeff-downloads
Oct 20, 2026
Merged

shimwell merged 3 commits into
mainfrom
jeff-downloads

Conversation

@shimwell

@shimwell shimwell commented Oct 20, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Download official OpenMC JEFF 3.3/4.0 HDF5 libraries (default 4.0), including release-specific ENDF/B photon supplements.
  • Preserve download, extraction and cleanup options, with release-scoped directories below the destination parent.
  • Simplify CLI declarations and consolidate offline tests into parameterized matrices: 379 → 285 added lines.
  • Keep README documentation in the existing download table, with a neutron-temperature column for ENDF/B, JEFF and TENDL instead of a JEFF-only paragraph.

Validation

  • 322 offline tests passed, 1 environment-dependent skip; CLI help and Python 3.8 syntax checks passed.
  • No previously covered unchanged implementation lines lost coverage. The CLI matrix now exercises 44 additional combinations.
  • Both official URLs previously passed live checks; full multi-GB libraries were not downloaded.
  • README-only follow-up: checked table structure, GitHub rendering and unchanged surrounding sections. Temperatures verified against OpenMC and the TENDL 2019/2021 HDF5 documentation; no code or tests changed.

Based on main after #43. CI policy and the single explicitly untested URL are unchanged. All commits and this PR are attributed to shimwell.

@shimwell

Copy link
Copy Markdown
Member Author

CI prerequisite: #43. Please merge that first; this PR will then be rebased and the shared CI/test changes removed from its feature diff. The new JEFF HDF5 URLs passed checks; existing external-host failures are documented separately in #43. Flat test organization updates are prepared locally. All commits remain attributed to shimwell.

@shimwell
shimwell merged commit 6bb904e into main Oct 20, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant