Skip to content

Access element subshell map data only if it has atomic relaxation data#4020

Merged
paulromano merged 1 commit into
openmc-dev:developfrom
GuySten:atomic-relaxation-fix
Jul 17, 2026
Merged

Access element subshell map data only if it has atomic relaxation data#4020
paulromano merged 1 commit into
openmc-dev:developfrom
GuySten:atomic-relaxation-fix

Conversation

@GuySten

@GuySten GuySten commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Description

Currently openmc access element subshell map data for elements without atomic relaxation data.
This PR fix that with a simple guard.

I've tested that this works with FENDL data.
I did not add a test because we do not have an element without relaxation data in the test data.

Fixes #3992

Checklist

  • I have performed a self-review of my own code
  • I have run clang-format (version 18) on any C++ source files (if applicable)
  • I have followed the style guidelines for Python source files (if applicable)
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

@GuySten
GuySten requested review from amandalund and paulromano July 15, 2026 18:38
@GuySten GuySten added the Bugs label Jul 15, 2026

@paulromano paulromano left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy fix -- thanks @GuySten!

@paulromano
paulromano merged commit d3bc166 into openmc-dev:develop Jul 17, 2026
18 checks passed
@GuySten
GuySten deleted the atomic-relaxation-fix branch July 17, 2026 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OpenMC 0.15.3 segmentation fault with FENDL photoatomic data

2 participants