Handle omitted optional HDF5 strings in Python readers - #4118
Merged
paulromano merged 4 commits intoSep 9, 2026
Conversation
GuySten
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is an alternative to #4088 that preserves the existing HDF5 convention of omitting empty string attributes and datasets. Rather than changing the low-level string writer and every file it produces, this PR makes readers that consume optional strings supply the appropriate default when a field is absent. In particular:
StatePoint.pathnow returns an empty string when the statepoint has nopathattribute. This fixes the MWE from Write empty strings to hdf5 #4088, whereModel.run()does not pass an input path and the C++ writer consequently omits the empty attribute.UnstructuredMesh.from_hdf5()now accepts a missingfilenamedataset. A filename is unavailable when an unstructured mesh was constructed from an in-memory mesh rather than a file, which also resolvesLibMesh::filename_attribute not written when pointer-based constructors are used. #2285.Closes #2285
Checklist
I have run clang-format (version 18) on any C++ source files (if applicable)