Repository navigation
Fix DA for (n,p3He) and (n,d3He) entries in DADZ - #4210
Conversation
Wrong ΔA sum.
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Correct DADZ reaction values openmc/data/data.py |
The (n,p3He) entry changes from (-4, -3) to (-3, -3). The (n,d3He) entry changes from (-5, -3) to (-4, -3). |
Estimated code review effort: 1 (Trivial) | ~3 minutes
Change: Bug fix
Merge Risk: 
27543
-
The data correction is mergeable; external user-generated chains may need regeneration separately.
Pre-merge checks: 
-
Check name Status Explanation Resolution Description check The author gave a one-line description: "Wrong ΔA sum." It says all chains with these reactions need regeneration and tags a maintainer. It does not summarize the change, state which entries change, o… Expand the Description section. Name the DADZ entries changed for (n,p3He) and (n,d3He), state the old and new ΔA values, and explain why they were wrong. Add the issue or PR reference in the "Fixes # (issue)" line. Complete the AI Assistan… -
Check name Status Explanation Title check The title clearly identifies the two affected reactions and the correction to their DADZ values. Docstring Coverage No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files.
-
Full details: Description check
-
Explanation
The author gave a one-line description: "Wrong ΔA sum." It says all chains with these reactions need regeneration and tags a maintainer. It does not summarize the change, state which entries change, or link an issue. The template's Description, Fixes # (issue), and AI Assistance sections are missing, and no checklist items are marked.
Resolution
Expand the Description section. Name the DADZ entries changed for (n,p3He) and (n,d3He), state the old and new ΔA values, and explain why they were wrong. Add the issue or PR reference in the "Fixes # (issue)" line. Complete the AI Assistance section: write "None" if no AI tool was used, or list the harness, model, and reasoning effort. Review the checklist and mark each item that applies. State whether tests cover the change, or whether the chain regeneration was run.
-
Finishing Touches
-
Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
yrrepy
changed the title
|
Thanks for this fix. I guess this means we have quite a few chain files to remake |
Wrong ΔA sum.
All chains including these reactions should be regenerated. FYI @shimwell
Summary by CodeRabbit
(n,p3He)and(n,d3He)entries.