chore: run formatting and linting on files and reenable in the pipeline - #250
Merged
Conversation
Signed-off-by: aaronschweig <aaron.schweig@gmail.com>
|
Warning Review limit reached
Next review available in: 20 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughChangesThe pipeline now runs ESLint and Prettier checks. Documentation tables and examples were reformatted. Angular templates, TypeScript, Sass, tests, stories, configuration, and bundle scripts received formatting updates. Form and resource-field templates also include direct index usage and related markup changes. Formatting and validation
Estimated code review effort: 2 (Simple) | ~15 minutes 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
aaronschweig
enabled auto-merge (squash)
August 12, 2026 15:43
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/declarative-table.md`:
- Line 22: Update the external script element in the declarative table
documentation to use an explicit paired closing tag instead of self-closing
syntax, ensuring subsequent inline initialization remains outside the external
script and executes correctly.
In
`@projects/ngx/declarative-ui/resource-field/resource-collection-field/resource-collection-field.component.html`:
- Line 24: Add a click handler to the `.card__body` element in the
`mfp-resource-field` template that stops event propagation, preventing clicks on
expanded collection values from reaching the enclosing `ui5-table-row` and
triggering `onRowClick(item)`.
In `@projects/ngx/declarative-ui/resource-field/resource-field.component.html`:
- Around line 27-35: Remove the non-null assertions from the bindings in the
display branches of the resource-field template. Ensure the conditions or
component state narrow boolValue() and stringValue() to defined values before
passing them to BooleanValue and LinkValue; otherwise, explicitly handle the
undefined case. If an assertion is unavoidable, document its invariant at the
relevant symbol.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: ca221542-8c1f-4a27-a39d-d35be7c90e37
📒 Files selected for processing (93)
.github/workflows/pipeline.yamlAGENTS.mdCHANGELOG.mdREADME.mddocs/dashboard.mddocs/declarative-form.mddocs/declarative-table-card.mddocs/declarative-table.mddocs/resource-field.mddocs/test-ids.mdprojects/ngx/README.mdprojects/ngx/cards/favorites/favorites.component.htmlprojects/ngx/cards/favorites/favorites.component.scssprojects/ngx/cards/favorites/favorites.component.tsprojects/ngx/cards/mock-card/mock-card.component.scssprojects/ngx/cards/service-status/service-status-card.component.htmlprojects/ngx/cards/service-status/service-status-card.component.scssprojects/ngx/cards/service-status/service-status-card.component.tsprojects/ngx/cards/stories/visited-service-card.stories.tsprojects/ngx/cards/whats-new/whats-new.component.scssprojects/ngx/cards/whats-new/whats-new.component.tsprojects/ngx/declarative-ui/dashboard/card/dashboard-card.component.htmlprojects/ngx/declarative-ui/dashboard/card/dashboard-card.component.scssprojects/ngx/declarative-ui/dashboard/card/dashboard-card.component.spec.tsprojects/ngx/declarative-ui/dashboard/card/utils/dashboard-card-registry.spec.tsprojects/ngx/declarative-ui/dashboard/card/utils/dashboard-card-registry.tsprojects/ngx/declarative-ui/dashboard/card/utils/mount-angular-card.spec.tsprojects/ngx/declarative-ui/dashboard/card/utils/mount-sap-card.spec.tsprojects/ngx/declarative-ui/dashboard/card/utils/mount-wc-card.spec.tsprojects/ngx/declarative-ui/dashboard/constants/constants.tsprojects/ngx/declarative-ui/dashboard/constants/index.tsprojects/ngx/declarative-ui/dashboard/dashboard/dashboard-element-methods.spec.tsprojects/ngx/declarative-ui/dashboard/dashboard/dashboard.component.htmlprojects/ngx/declarative-ui/dashboard/dashboard/dashboard.component.scssprojects/ngx/declarative-ui/dashboard/dashboard/dashboard.component.tsprojects/ngx/declarative-ui/dashboard/dashboard/engines/zflow/resize.helpers.spec.tsprojects/ngx/declarative-ui/dashboard/dashboard/engines/zflow/resize.helpers.tsprojects/ngx/declarative-ui/dashboard/dashboard/engines/zflow/z-flow-engine.tsprojects/ngx/declarative-ui/dashboard/dashboard/engines/zflow/z-flow.helpers.spec.tsprojects/ngx/declarative-ui/dashboard/discard-changes-dialog/discard-changes-dialog.component.htmlprojects/ngx/declarative-ui/dashboard/discard-changes-dialog/discard-changes-dialog.component.spec.tsprojects/ngx/declarative-ui/dashboard/discard-changes-dialog/discard-changes-dialog.component.tsprojects/ngx/declarative-ui/dashboard/edit-cards-dialog/edit-cards-dialog.component.htmlprojects/ngx/declarative-ui/dashboard/edit-cards-dialog/edit-cards-dialog.component.spec.tsprojects/ngx/declarative-ui/dashboard/edit-cards-dialog/edit-cards-dialog.component.tsprojects/ngx/declarative-ui/dashboard/section/dashboard-section.component.htmlprojects/ngx/declarative-ui/dashboard/section/dashboard-section.component.spec.tsprojects/ngx/declarative-ui/dashboard/section/dashboard-section.component.tsprojects/ngx/declarative-ui/dashboard/unsaved-changes-dialog/unsaved-changes-dialog.component.htmlprojects/ngx/declarative-ui/dashboard/unsaved-changes-dialog/unsaved-changes-dialog.component.spec.tsprojects/ngx/declarative-ui/dashboard/unsaved-changes-dialog/unsaved-changes-dialog.component.tsprojects/ngx/declarative-ui/dialogs/delete-confirmation-dialog/delete-confirmation-dialog.component.htmlprojects/ngx/declarative-ui/dialogs/resource-form-dialog/resource-form-dialog.component.htmlprojects/ngx/declarative-ui/form/declarative-form/declarative-form.component.htmlprojects/ngx/declarative-ui/form/declarative-form/declarative-form.component.tsprojects/ngx/declarative-ui/form/declarative-form/form-collection-field/form-collection-field.component.htmlprojects/ngx/declarative-ui/form/declarative-form/form-collection-field/form-collection-field.component.tsprojects/ngx/declarative-ui/form/utils/set-property-by-path.tsprojects/ngx/declarative-ui/models/ui-definition.tsprojects/ngx/declarative-ui/resource-field/boolean-value/boolean-value.component.htmlprojects/ngx/declarative-ui/resource-field/boolean-value/boolean-value.component.tsprojects/ngx/declarative-ui/resource-field/link-value/link-value.component.htmlprojects/ngx/declarative-ui/resource-field/link-value/link-value.component.tsprojects/ngx/declarative-ui/resource-field/resource-collection-field/resource-collection-field.component.htmlprojects/ngx/declarative-ui/resource-field/resource-field.component.htmlprojects/ngx/declarative-ui/resource-field/resource-field.component.spec.tsprojects/ngx/declarative-ui/resource-field/secret-value/secret-value.component.htmlprojects/ngx/declarative-ui/resource-field/tag-list-value/tag-list-value.component.htmlprojects/ngx/declarative-ui/resource-field/tag-list-value/tag-list-value.component.spec.tsprojects/ngx/declarative-ui/stories/dashboard.stories.tsprojects/ngx/declarative-ui/stories/declarative-table.stories.tsprojects/ngx/declarative-ui/stories/delete-confirmation-dialog.stories.tsprojects/ngx/declarative-ui/stories/discard-changes-dialog.stories.tsprojects/ngx/declarative-ui/stories/edit-cards-dialog.stories.tsprojects/ngx/declarative-ui/stories/resource-form-dialog.stories.tsprojects/ngx/declarative-ui/stories/unsaved-changes-dialog.stories.tsprojects/ngx/declarative-ui/table-card/declarative-table-card.component.htmlprojects/ngx/declarative-ui/table-card/declarative-table-card.component.scssprojects/ngx/declarative-ui/table-card/declarative-table-card.component.spec.tsprojects/ngx/declarative-ui/table-card/filter-tabs/filter-tabs.component.htmlprojects/ngx/declarative-ui/table-card/filter-tabs/filter-tabs.component.tsprojects/ngx/declarative-ui/table-card/models/configs.tsprojects/ngx/declarative-ui/table/declarative-table/declarative-table.component.htmlprojects/ngx/declarative-ui/table/declarative-table/declarative-table.component.scssprojects/ngx/declarative-ui/table/declarative-table/declarative-table.component.spec.tsprojects/ngx/declarative-ui/table/utils/proccess-fields.spec.tsprojects/ngx/declarative-ui/table/utils/proccess-fields.tsprojects/ngx/declarative-ui/table/utils/rules.engine.spec.tsprojects/ngx/declarative-ui/table/utils/rules.engine.tsprojects/webcomponents/README.mdrenovate.jsonscripts/bundle-wc.mjstsconfig.storybook.json
💤 Files with no reviewable changes (3)
- projects/ngx/declarative-ui/table-card/declarative-table-card.component.scss
- projects/ngx/declarative-ui/table-card/models/configs.ts
- projects/ngx/declarative-ui/dashboard/card/utils/dashboard-card-registry.ts
Signed-off-by: aaronschweig <aaron.schweig@gmail.com>
gkrajniak
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #245
Summary by CodeRabbit
New Features
Bug Fixes
Documentation
Style