Skip to content

TEST Add sparse dataset inclusion coverage for row ID and ignore attributes. #1749

Description

@vasuappu

Description :-

This PR improves the regression test coverage for sparse dataset retrieval when row ID and ignored attributes are configured for the dataset.

The existing test already defined a row ID attribute and an ignored attribute, but the retrieval operation was performed with both inclusion options disabled. As a result, the test confirmed that these attributes were excluded from the returned feature data, but it did not verify what happens when a caller explicitly requests them.

This change extends the test so that the inclusion behaviour is also checked. The dataset is retrieved with both include_row_id=True and include_ignore_attribute=True, allowing the test to verify that the additional attributes are correctly represented in the returned feature matrix.

The new assertions also check the dimensions of the returned data and the associated categorical information. This ensures that the test does not only execute successfully, but also confirms that the returned dataset has the expected structure.

Changes :-

  1. Extended the existing sparse dataset test to cover the case where row ID attributes are explicitly included in the returned features.

  2. Added coverage for retrieving attributes that were previously marked as ignored by using include_ignore_attribute=True

  3. Verified that enabling both inclusion options results in a feature matrix with the expected shape (600, 20000)

  4. Added a check for the length of the categorical indicator list to ensure it corresponds to all 20,000 returned features.

  5. Verified that every categorical indicator is False, matching the expected characteristics of the returned sparse dataset.

  6. Added an assertion for the target data to confirm that the returned target has the expected shape (600,)

  7. Kept the existing exclusion behaviour covered so that the test continues to validate both inclusion and exclusion scenarios.
    Testing

The updated sparse dataset test was executed using the following command:

bash
pytest tests/test_datasets/test_dataset.py::OpenMLDatasetTestSparse::test_get_sparse_dataset_rowid_and_ignore_and_target

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions