[Bugfix] Remove "Apply encoder settings" log - #8
Merged
Conversation
ghbogarin
force-pushed
the
fix/apply-encoder-settings-once
branch
from
August 5, 2026 18:19
82db772 to
797b525
Compare
JoaquinBCh
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Each time the "Settings" menu was opened on OBS, an INFO level log "info: [obs-moq] apply encoder settings" would appear ~8 times.
Upon inspecting the function, I concluded that the function is called each time OBS needs to read the restrictions we've applied to the encoder. The name "ApplyEncoderSettings" is not ideal and doesn't reflect what's actually done, but it's the name defined by libobs. While I think in our code, it'd be nice to rename that function, I don't think it's worth losing the sync with libobs's info.apply_encoder_settings
This change is