Skip to content

Fix moving NPC vehicle pitch not synced - #1249

Open
Fanorisky wants to merge 3 commits into
openmultiplayer:masterfrom
Fanorisky:master
Open

Fix moving NPC vehicle pitch not synced#1249
Fanorisky wants to merge 3 commits into
openmultiplayer:masterfrom
Fanorisky:master

Conversation

@Fanorisky

Copy link
Copy Markdown

rotation sent in driver sync previously only used yaw, so moving npc vehicles looked flat instead of tilting toward their direction of travel.
now pitch is calculated from position vs target position while moving_, then combined with yaw before sync.

@eakwarp

eakwarp commented Aug 7, 2026

Copy link
Copy Markdown

@AmyrAhmady maybe its time?)
I tested the current implementation in all possible variants, and it's either this or NPC_SetQuaternion (from #1206 ) is needed

@AmyrAhmady AmyrAhmady left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments and some empty line breaks are removed for some reason

Comment thread Server/Components/NPCs/NPC/npc.cpp
Comment thread Server/Components/NPCs/NPC/npc.cpp Outdated
@Fanorisky
Fanorisky requested a review from AmyrAhmady August 7, 2026 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants