Repository navigation
camera: Let exec() take the timeout for stopping the running script. - #30
Merged
Merged
Conversation
Member
|
I think the default stop() timeout should have been timeout = self.timeout if timeout is None else timeoutThere's nothing you can do to forcibly stop a script and run another one, if that script catches |
…eout. stop() waits for the running script to exit for as long as it takes unless a timeout is given, and exec() forwards its timeout to stop(). A dead link is still bounded by the transport timeout and resync.
kwagyeman
force-pushed
the
fix/exec-stop-timeout
branch
from
November 8, 2026 08:18
500afc8 to
d7f7621
Compare
Member
Author
|
That works, it's safe too as the transport will break underneath if there's a comm issue. |
iabdalkader
approved these changes
Nov 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
exec() stops a running script first, but calls stop() with the default timeout and gives the caller no way to change it. A script that takes longer than that to exit, e.g. a KeyboardInterrupt handler that cleans up, makes exec() raise TimeoutException.
Add
timeoutto exec() and pass it through to stop(). Default unchanged.Tested on an N6 with a script that sleeps 2 s in its KeyboardInterrupt handler:
exec(script)raises after 1 s as before,exec(script, timeout=6)runs the new script after 2.6 s.While a KeyboardInterrupt handler is rare, Claude found this while testing a boot.py that takes 2 seconds or longer to finish - you'd hit this in the case of customizing boot.py.