Conversation
This was referenced Sep 17, 2026
tt-a1i
reviewed
Sep 21, 2026
tt-a1i
left a comment
Collaborator
There was a problem hiding this comment.
审查提交:e548f97d90aa52840d74f90b414a7e215dc7b6b6。
本轮未发现新的阻断问题。以下结论仅覆盖所列验证范围,不是合并批准。
验证范围
Full production, test and research-record diff inspected. Frozen head 36 file-mutation-display and workspace-cleanup-guard tests passed, including real ToolExecutionComponent event invalidation and session isolation.
限制与后续
No independent PTY smoke in this audit. Author documents controlled macOS TUI approval/refusal evidence with provenance; does not claim Linux visual reproduction. Approval enforcement unchanged; only operator-facing confirmation phase is projected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fixes #544. Pi emits
tool_execution_startbefore OpenPI’stool_callcleanup guard finishes. While a guardedrmis awaiting confirmation, the compact Bash row incorrectly saysRunning rm keep.txtand advances a timer, although the command has not executed.Value
Users can distinguish a pending decision from active Bash execution. The waiting row does not keep animating or repainted every second while a person decides.
Approach
The cleanup guard publishes the confirmation phase on Pi’s extension EventBus with Session and tool-call identity. The TUI-only file-mutation display projects it as
Awaiting approval, clears its execution timer during the wait, and resumesRunningafter approval. Refusal/cancellation remains awaiting until the blocked result is shown. The guard decision, confirmation choices/default, actual tool definition and execution semantics are unchanged.The source-scoped investigation is recorded in
docs/research/ISSUE_544_CLEANUP_CONFIRMATION_UI_2026-09-17.md.Validation
bun run check: passed (using Bun 1.3.14 via npm exec in this shell).bun run test: 1661 passed, 1 skipped, 0 failed; Vitest 220 passed.f6b49ae: holding confirmation for >3 seconds showed oneAwaiting approvalrow and noRunning rm keep.txtrow during the wait. Esc preserved the pre-existing file; approval resumed running and deleted it.Runningrows back, so it remains necessary.Impact
read/grepflashing is not reproduced on current main and is not addressed by this PR.