Conversation
tt-a1i
reviewed
Sep 21, 2026
tt-a1i
left a comment
Collaborator
There was a problem hiding this comment.
审查提交:e556d5dff1aaf134c9d521b92c663e2d58129eab。
本轮未发现新的阻断问题。以下结论仅覆盖所列验证范围,不是合并批准。
验证范围
Full source and tests diff reviewed. Artifact evidence-view component tests passed, including language switching with an open preview, structured errors, unchanged file content and stale-preview warnings.
限制与后续
Did not rerun real browser artifact E2E. Unknown API codes and generic Error messages retain server text as fallback; no change to access/download authority. Branch requires current-main integration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Refs #350. In the Chinese Web workbench, the file-preview dialog still used English for its title, actions, read-only/version details, truncation notice, accessibility names, and artifact failures.
Value
The preview can be inspected and operated consistently in the active language without changing the file contents or the authority of the read-only artifact path.
Approach
Validation
bun run check: passed (config/docs/discipline, Web build/typecheck, format, lint, TypeScript).bun run test: Node 1658 passed, 1 platform skip; Vitest 221 passed.vitest run tests/web/evidence-view.spec.ts: 6/6 after removing an unnecessary test Provider wrapper (ablation).playwright test --config tests/web/playwright.config.ts tests/web/artifact-evidence.e2e.ts: 1/1, zh-CN fixture, verified download, refresh, missing-file error, and axe checks. No model call.main@f6b49ae59605b1276b8267f2886d22c03f01533c; isolatedpi listshowed the single OpenPI source at this worktree. No claim about an npm-installed runtime.Before (Chinese page, English preview):
After (same fixture, Chinese preview):
Impact
WebApiErrorcodes; unknown error messages continue to display their original diagnostics. Other Web surfaces and language preference ownership are unchanged.