Conversation
tt-a1i
requested changes
Sep 21, 2026
tt-a1i
left a comment
Collaborator
There was a problem hiding this comment.
审查提交:0cd022d5ae42785e9e4bf41164b7f595e817235e。
需要修改后再合并。
具体问题
P2 — 同步且无超时的 trash 命令可冻结整个 Pi 进程 · extensions/sessions/sessions.ts:440
Synthetic trash helper sleeps 2 seconds; deleteSessionFile blocks before returning its Promise and 10ms timer cannot fire. No timeout/cancellation; a stalled helper can hang indefinitely. Use bounded async process execution.
验证范围
Complete three-file diff inspected; session tests and isolated fake-trash reproduction saved. Active-session rejection and confirm/cancel wiring inspected.
限制与后续
No real TUI acceptance or Windows recycle-bin integration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #551.
This PR adds a
Ctrl+Dshortcut to delete sessions directly from the/sessionspicker:Ctrl+Don a selected session triggers the deletion workflow.Delete session? Enter confirm · Esc cancelto prevent accidental deletion.trashCLI when available, falling back to permanentunlink.deleteSessionFileundertests/extensions/sessions/sessions.test.ts.Testing
node --test --experimental-strip-types tests/extensions/sessions/sessions.test.ts(7 passed, 0 failed)Ctrl+Dtriggers deletion confirmation,Enterdeletes the file and refreshes list,Escsafely cancels.