Upgrade Java matrix axes that setup-java reads through ${{ matrix.* }} - #231
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SetupJavaUpgradeJavaVersiononly rewrote literaljava-versionvalues, sojava-version: ${{ matrix.java }}withstrategy.matrix.java: [ '17' ]stayed at 17 after a Java 25 migration. Now, per job, the axes asetup-javastep references through${{ matrix.<axis> }}get their values upgraded like a literal would be, duplicates collapse ([ '11', '17' ]becomes[ '25' ]), and a matrix withincludeorexcludeis left alone since those encode relationships between axes.Found by a team of coding agents reviewing a Moderne run of
org.openrewrite.java.migrate.UpgradeToJava25over eight open-source repositories (run 20261003103223-WtyA8). The issue issetup-java-matrix-versionin the run'sio.moderne.RecipeIssuesdata table, and the fix was discussed and reviewed on the run's message board. A row from the table, as a generalized example:The migration leaves the setup-java matrix at Java 17 while the build and migrated sources require Java 25. (
spring-projects/spring-petclinic,.github/workflows/maven-build.yml)Before:
What the recipe produced:
Expected: