Upgrade explicit Java versions in pom.xml files that have no Maven model - #1252
Merged
jkschneider merged 2 commits intoOct 3, 2026
Merged
jkschneider merged 2 commits into
jkschneider merged 2 commits into
Conversation
jkschneider
force-pushed
the
java25/alternate-maven-java-version
branch
from
October 3, 2026 15:51
3b963b8 to
ac53042
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A repository built with Gradle can also carry a
pom.xml(spring-petclinic does). The LST parses it as plain XML with noMavenResolutionResult, soUpdateMavenProjectPropertyJavaVersionnever sees it: after the migration the Gradle build targets 25 while the Maven build still says 17 and cannot compile sources that use Java 25 APIs. NewUpgradeUnmodeledMavenJavaVersion, added toUpgradeJavaVersion, raises explicit numericjava.versionandmaven.compiler.{release,source,target}properties andmaven-compiler-pluginrelease/source/targetsettings below the target in apom.xmlthat has no Maven marker. Property references and compiler plugins with a custom groupId are left alone (second commit).Found by a team of coding agents reviewing a Moderne run of
org.openrewrite.java.migrate.UpgradeToJava25over eight open-source repositories (run 20261003103223-WtyA8). The issue isalternate-maven-java-versionin the run'sio.moderne.RecipeIssuesdata table, and the fix was discussed and reviewed on the run's message board. A row from the table, as a generalized example:The Gradle migration leaves the alternate Maven build targeting Java 17 although migrated sources require Java 25. (
spring-projects/spring-petclinic,pom.xml)Before:
What the recipe produced:
Expected:
Stacked on #1251 (3 of 9); merge that one first.