Simplify the dead thread-group fallback left by SystemGetSecurityManagerToNull - #1255
Merged
jkschneider merged 2 commits intoOct 3, 2026
Merged
Conversation
jkschneider
force-pushed
the
java25/security-manager-thread-group
branch
from
October 3, 2026 15:51
faa05f1 to
9810bb8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After
System.getSecurityManager()becomesnull, the common idiomkeeps a dead local and a dead branch;
SimplifyConstantIfBranchExecutionhandlesif, not this ternary. NewSimplifySecurityManagerThreadGroup, added to the composite right after the replacement: when a nullSecurityManagerlocal is used only in the immediately followings != null ? s.getThreadGroup() : <fallback>assignment, drop the local and assign the fallback. Anything with comments, more references or another shape is left alone (the second commit adds the comment guards).Found by a team of coding agents reviewing a Moderne run of
org.openrewrite.java.migrate.UpgradeToJava25over eight open-source repositories (run 20261003103223-WtyA8). The issue issecurity-manager-null-localin the run'sio.moderne.RecipeIssuesdata table, and the fix was discussed and reviewed on the run's message board. A row from the table, as a generalized example:Replacing getSecurityManager with null leaves a dead local and a dead conditional branch. (
rrd4j/rrd4j,src/main/java/org/rrd4j/core/RrdSyncThreadPool.java)Before:
What the recipe produced:
Expected:
Stacked on #1254 (6 of 9); merge that one first.