Upgrade cimg/openjdk CI job containers when upgrading Java - #1258
Merged
jkschneider merged 1 commit intoOct 3, 2026
Merged
Conversation
jkschneider
added this pull request to stack #1259
October 3, 2026 15:34
jkschneider
force-pushed
the
java25/ci-container-image
branch
from
October 3, 2026 15:52
7d0ddc3 to
7530506
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CircleCI's
docker: - image: cimg/openjdk:17.0and a GitHub Actionscontainer: cimg/openjdk:22.0keep an older JDK that cannot compile or load the migrated classes. NewUpgradeJavaCiContainerImage, added toUpgradeJavaVersion: in.github/workflows/*.ymland.circleci/config.yml, raisecimg/openjdk:<major>.<minor>[-variant]below the target tocimg/openjdk:<version>.0[-variant], leaving newer versions and other images alone.Found by a team of coding agents reviewing a Moderne run of
org.openrewrite.java.migrate.UpgradeToJava25over eight open-source repositories (run 20261003103223-WtyA8). The issue isci-container-java-versionin the run'sio.moderne.RecipeIssuesdata table, and the fix was discussed and reviewed on the run's message board. A row from the table, as a generalized example:CI job containers retain an older Java version that cannot compile or load the migrated Java 25 classes. (
rrd4j/rrd4j,.circleci/config.yml)Before:
What the recipe produced:
Expected:
Stacked on #1257 (9 of 9); merge that one first.